Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

reset visible tooltip list before setting new one #16

Merged
merged 1 commit into from
Dec 2, 2023

Conversation

pseudoankit
Copy link
Owner

@pseudoankit pseudoankit commented Dec 2, 2023

Issue : #14

Reason - Once coachmarks are displayed I was setting last and current visible to null
but not _visibleTooltips and when user wants to show new coachmarks
I was setting _visibleTooltipIndex to 0 and setter of this variable was again assigning last coachmark's 0th item to current and next iteration was setting it to last visible

Solution - rest _visibleTooltips once we are setting up new values

@pseudoankit pseudoankit merged commit 6284283 into master Dec 2, 2023
1 check passed
@pseudoankit pseudoankit deleted the fix-showing-last-tooltip branch December 2, 2023 18:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant